Re: [PATCH 2/2] kbuild: deb-pkg: add KDEB_SOURCE_COMPRESS to specify compression type

[Ben Hutchings]

On Thu, 2023-04-20 at 16:17 +0900, Masahiro Yamada wrote:
> On Thu, Apr 20, 2023 at 5:34 AM Nicolas Schier <nicolas@xxxxxxxxx> wrote:
[...]
> > > +KDEB_SOURCE_COMPRESS ?= gzip
> > 
> > According to dpkg-source(1), xz is the default compression for deb
> > source format >= 2.  Shouldn't we use xz here by default as well?
> 
> 
> Yes.
> xz is the default because we switched to format 3.0 (quilt).
> 
> But, we used gzip for a long time, so I did not change it
> in this commit.
> 
> 
> I do not have a strong opinion.
> 
> Ben (debian kernel maintainer) is in the CC list,
> perhaps he has some preference.

I think it makes sense to keep source compression unchanged in this
commit, but you could add another commit to change the default.

Ben.

-- 
Ben Hutchings
Theory and practice are closer in theory than in practice - John Levine

Attachment: signature.asc
Description: This is a digitally signed message part