Re: [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree

[Chao Yu]

On 2023/4/22 3:20, Jaegeuk Kim wrote:
> On 04/21, Chao Yu wrote:
> > On 2023/4/18 14:09, Qi Han wrote:
> > > This comment make no sense and is in the wrong place, so let's
> > > remove it.
> > >
> > > Signed-off-by: Qi Han <hanqi@xxxxxxxx>
> > > ---
> > >    fs/f2fs/extent_cache.c | 1 -
> > >    1 file changed, 1 deletion(-)
> > >
> > > diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> > > index 28b12553f2b3..1f6d7de35794 100644
> > > --- a/fs/f2fs/extent_cache.c
> > > +++ b/fs/f2fs/extent_cache.c
> > > @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
> > >    	if (!test_opt(sbi, AGE_EXTENT_CACHE))
> > >    		return false;
> > > -	/* don't cache block age info for cold file */
> > >    	if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
> > >    		return false;
> >
> > Should move it here instead of removal?
> >
> > /* don't cache block age info for cold file */
>
> Not worth to comment this, as the code is exactly saying that.

Correct.

Reviewed-by: Chao Yu <chao@xxxxxxxxxx>

Thanks,

> > >    	if (file_is_cold(inode))