Re: [RFT PATCH 1/3] arm64: dts: qcom: msm8996: correct /soc/bus ranges

From: Konrad Dybcio
Date: Sat Apr 22 2023 - 08:29:28 EST




On 20.04.2023 20:07, Krzysztof Kozlowski wrote:
> The bus@0 node should have reg or ranges to fix dtbs W=1 warnings:
>
> Warning (unit_address_vs_reg): /soc@0/bus@0: node has a unit name, but no reg or ranges property
> Warning (simple_bus_reg): /soc@0/bus@0: missing or empty reg/ranges property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> Please kindly test on hardware.
> ---
PCIe Wi-Fi still comes up and connects to the network
(it doesn't really work reliably but it never quite did -
brcmfmac is brcmfmac :/)

Tested-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> # MSM8996 Kagura
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad

> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index e160d5e6863f..a88d0a9bb7e5 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1832,7 +1832,7 @@ bus@0 {
> compatible = "simple-pm-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges;
> + ranges = <0x0 0x0 0xffffffff>;
>
> pcie0: pcie@600000 {
> compatible = "qcom,pcie-msm8996";