RE: [PATCH v2 8/8] mfd: max77658: Add ADI MAX77643/54/58/59 MFD Support

[Arslanbenzer, Zeynep]

On Thu, 30 Mar 2023, Lee Jones wrote:

>On Wed, 22 Mar 2023, Zeynep Arslanbenzer wrote:
>
>> MFD driver for MAX77643/MAX77654/MAX77658/MAX77659 to enable its sub
>
>Please drop all references to 'MFD'.
>
>What are these devices, really?  I suspect they are PMICs?
>
>> devices.
>>
>> The MAX77643 is a multi-function devices. It includes regulator.
>>
>> The MAX77654 is a multi-function devices. It includes regulator and 
>> charger.
>>
>> The MAX77658 is a multi-function devices. It includes regulator, 
>> charger and battery.
>>
>> The MAX77659 is a multi-function devices. It includes regulator and 
>> charger.
>>
>> Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@xxxxxxxxxx>
>> Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@xxxxxxxxxx>
>> ---
>>  drivers/mfd/Kconfig          |  15 ++
>>  drivers/mfd/Makefile         |   1 +
>>  drivers/mfd/max77658.c       | 448 +++++++++++++++++++++++++++++++++++
>>  include/linux/mfd/max77658.h |  88 +++++++
>>  4 files changed, 552 insertions(+)
>>  create mode 100644 drivers/mfd/max77658.c  create mode 100644 
>> include/linux/mfd/max77658.h
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 
>> 8b93856de432..7b4be7fb8662 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -821,6 +821,21 @@ config MFD_MAX77650
>>  	  the following functionalities of the device: GPIO, regulator,
>>  	  charger, LED, onkey.
>>
>> +config MFD_MAX77658
>> +	tristate "Analog Devices MAX77643/MAX77654/MAX77658/MAX77659 PMIC Support"
>> +	depends on I2C
>> +	depends on OF
>> +	select MFD_CORE
>> +	select REGMAP_I2C
>> +	select REGMAP_IRQ
>> +	help
>> +	  Say Y here to add support for Analog Devices
>> +	  MAX77643/MAX77654/MAX77658/MAX77659 Power Management IC.
>
>"MAX776xx series"?

As I realized later, max77620, max77650, max77686, and max77693 drivers were merged to Linux before our patch. They are also PMIC devices and our patch does not cover them. Therefore, I think it would not be appropriate to use MAX776xx.

>
>> +	  This is the core multifunction
>
>Just "core driver" is fine.
>
>Odd place to line wrap?
>
>> +	  driver for interacting with the device. Additional drivers can be
>
>"can be"?  It's probably pretty useless if you don't, no?
>
>> +	  enabled in order to use the following functionalities of the device:
>> +	  regulator, charger.
>
>"... in order to use the regular and charger functionality of the device".
>
>>  config MFD_MAX77686
>>  	tristate "Maxim Semiconductor MAX77686/802 PMIC Support"
>>  	depends on I2C
>> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 
>> 7ed3ef4a698c..f52aff45878f 100644
>> --- a/drivers/mfd/Makefile
>> +++ b/drivers/mfd/Makefile
>> @@ -163,6 +163,7 @@ obj-$(CONFIG_MFD_DA9150)	+= da9150-core.o
>>  obj-$(CONFIG_MFD_MAX14577)	+= max14577.o
>>  obj-$(CONFIG_MFD_MAX77620)	+= max77620.o
>>  obj-$(CONFIG_MFD_MAX77650)	+= max77650.o
>> +obj-$(CONFIG_MFD_MAX77658)	+= max77658.o
>>  obj-$(CONFIG_MFD_MAX77686)	+= max77686.o
>>  obj-$(CONFIG_MFD_MAX77693)	+= max77693.o
>>  obj-$(CONFIG_MFD_MAX77714)	+= max77714.o
>> diff --git a/drivers/mfd/max77658.c b/drivers/mfd/max77658.c new file 
>> mode 100644 index 000000000000..a1c6db48eb08
>> --- /dev/null
>> +++ b/drivers/mfd/max77658.c
>> @@ -0,0 +1,448 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later
>> +/*
>> + * Copyright (c) 2023 Analog Devices, Inc.
>> + * ADI driver for the MAX77643/MAX77654/MAX77658/MAX77659
>> + */
>
>No need to list every device.
>
>"MAX776xx series"?
>

Best regards,
Zeynep