Re: [PATCH 2/5] Glue code for optmized Chacha20 implementation for ppc64le.

[Danny Tsen]

Got it.  Will fix it.

Thanks.

-Danny


On 4/25/23 12:41 AM, Herbert Xu wrote:
> On Mon, Apr 24, 2023 at 02:47:23PM -0400, Danny Tsen wrote:
> > +static int chacha_p10_stream_xor(struct skcipher_request *req,
> > +				 const struct chacha_ctx *ctx, const u8 *iv)
> > +{
> > +	struct skcipher_walk walk;
> > +	u32 state[16];
> > +	int err;
> > +
> > +	err = skcipher_walk_virt(&walk, req, false);
> > +	if (err)
> > +		return err;
> > +
> > +	chacha_init_generic(state, ctx->key, iv);
> > +
> > +	while (walk.nbytes > 0) {
> > +		unsigned int nbytes = walk.nbytes;
> > +
> > +		if (nbytes < walk.total)
> > +			nbytes = rounddown(nbytes, walk.stride);
> > +
> > +		if (!static_branch_likely(&have_p10) ||
> You don't need the static branch in the Crypto API code since
> the registration is already conditional.
>
> Cheers,