Re: [RFC PATCH] regmap: force update_bits() to write to HW when reg is volatile

[Vaittinen, Matti]

On 4/28/23 14:35, Mark Brown wrote:
> On Fri, Apr 28, 2023 at 08:44:06AM +0300, Matti Vaittinen wrote:
>> In many cases the volatile registers are expected to be written to
>> regardless of the existing value (because, the value of a volatile
>> register can't be trusted to stay the same during RMW cycle). In fact, it
>> is questionable if the volatile registers and regmap_update_bits()
>> conceptually make sense without device specific map->reg_update_bits.
> 
> I think you're looking for regmap_write_bits() here.

Yes. Thanks for pointing this out to me. This is the functionality I 
searched for.

However, my question really was if the regmap_update_bits() (and 
regmap_set_bits() / regmap_clear_bits()) should automatically work as 
regmap_write_bits() for volatile registers. I'll take your answer as 
"no" - and try to remember just use regmap_write_bits() with volatile 
registers which may require forcing writing the value even when it is 
not changed. Thanks!

Yours,
	-- Matti


-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~