Re: [PATCH] platform/x86: asus-wmi: add support for ASUS screenpad

[Luke Jones]

On Thu, May 4 2023 at 09:22:03 +1200, Luke Jones <luke@xxxxxxxxxx> 
wrote:
> On Wed, May 3 2023 at 17:46:53 +0000, Barnabás Pőcze 
> <pobrn@xxxxxxxxxxxxxx> wrote:
> > Hi
> >
> >
> > 2023. május 3., szerda 6:02 keltezéssel, Luke D. Jones 
> > <luke@xxxxxxxxxx> írta:
> >
> > >  Add support for the WMI methods used to turn off and adjust the
> > >  brightness of the secondary "screenpad" device found on some 
> > > high-end
> > >  ASUS laptops like the GX650P series and others.
> >
> > Is it this one: https://www.asus.com/content/rog-screenpad-plus/ ?
> > Or is the "plus" version something different?
> >
> > If it's a "proper" screen, wouldn't it be better to add support for 
> > it
> > in the respective subsystems? E.g. why not register a backlight 
> > device?
>
> I think it is similar yes, likely the same thing.
>
> Adding as a proper backlight is what I wanted to do but at first 
> blush I wasn't sure.
>
> Looking at include/linux/backlight.h + some examples it looks clear 
> now. I'll try to
> work up a revised patch and get it tested by the folks with the 
> actual laptop.
>
> My only possible issue would be how to handle the on/off part?
>
> Cheers,
> Luke.

This has now been addressed with "[PATCH v2 0/1] platform/x86: 
asus-wmi: add support for ASUS screenpad" at 
https://lkml.org/lkml/2023/5/5/9