Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void
From: Uwe Kleine-König
Date: Mon May 08 2023 - 09:43:39 EST
On Thu, Apr 13, 2023 at 08:00:04AM +0200, Uwe Kleine-König wrote:
> On Wed, Apr 12, 2023 at 09:30:05PM +0000, Leo Li wrote:
> > > On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-König wrote:
> > > > Hello,
> > > >
> > > > many bus remove functions return an integer which is a historic
> > > > misdesign that makes driver authors assume that there is some kind of
> > > > error handling in the upper layers. This is wrong however and
> > > > returning and error code only yields an error message.
> > > >
> > > > This series improves the fsl-mc bus by changing the remove callback to
> > > > return no value instead. As a preparation all drivers are changed to
> > > > return zero before so that they don't trigger the error message.
> > >
> > > Who is supposed to pick up this patch series (or point out a good reason for
> > > not taking it)?
> > Previously Greg KH picked up MC bus patches.
> > If no one is picking up them this time, I probably can take it through
> > the fsl soc tree.
> I guess Greg won't pick up this series as he didn't get a copy of it :-)
> Browsing through the history of drivers/bus/fsl-mc there is no
> consistent maintainer to see. So if you can take it, that's very
My mail was meant encouraging, maybe it was too subtile? I'll try again:
Yes, please apply, that would be wonderful!
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Description: PGP signature