Re: [PATCH v9 4/5] spi: dw: Add DMA address widths capability check
From: Joy Chakraborty
Date: Tue May 09 2023 - 04:26:16 EST
On Mon, May 8, 2023 at 6:46 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Thu, Apr 27, 2023 at 12:33:13PM +0000, Joy Chakraborty wrote:
> > Store address width capabilities of DMA controller during init and check
> > the same per transfer to make sure the bits/word requirement can be met.
> >
> > Current DW DMA driver requires both tx and rx channel to be configured
> > and functional hence a subset of both tx and rx channel address width
> > capability is checked with the width requirement(n_bytes) for a
> > transfer.
>
> This breaks an x86 allmodconfig build:
>
> /build/stage/linux/drivers/spi/spi-dw-dma.c: In function ‘dw_spi_dma_caps_init’:
> /build/stage/linux/drivers/spi/spi-dw-dma.c:100:1: error: control reaches end of non-void function [-Werror=return-type]
> 100 | }
> | ^
> cc1: some warnings being treated as errors
Moving "return 0" at the end of dw_spi_dma_caps_init() from patch
[4/5] to patch [3/5] to solve this and sending a V10 Patch.
Thanks
Joy