Re: [PATCH] ALSA: PCM: Fix codestyle issues in pcm_native.c

From: Ivan Orlov
Date: Wed May 10 2023 - 05:18:16 EST

On 10.05.2023 12:21, Oswald Buddenhagen wrote:
On Wed, May 10, 2023 at 10:06:16AM +0200, Takashi Iwai wrote:
Also, if it's only about white space fix or some indent level issues,
that could be rather more noise and disturbs the git change history,
e.g. it makes difficult to find out the real code changes via git
blame, especially it touches a huge amount of lines like this.

That said, I'm not going to take such "coding style cleanup" patch
blindly.  If it's associated with other real fix or enhancement, I'll
happily take it.  Otherwise, I'd rather leave it.

a maybe less confusing way to put it would be "do whitespace cleanups only on the lines that contain "real" changes, and maybe in their immediate proximity for consistency". that means that whitespace-only patches are by definition not acceptable.


Oswald, Takashi, thank you for the explanation! I got it. The acceptance of codestyle cleanup patches vary from one Kernel area to another. I'm curious about the sound subsystem, and decided to fix some obvious things before going to more significant enhancements I probably would able to make.

Kind regards,
Ivan Orlov.