Re: [PATCH v2 5/6] dt-bindings: memory-region property for tegra186-bpmp

From: Thierry Reding
Date: Wed May 10 2023 - 10:40:44 EST

On Wed, May 10, 2023 at 02:31:34PM +0300, Peter De Schrijver wrote:
> Add memory-region property to the tegra186-bpmp binding to support
> Co-developed-by: Stefan Kristiansson <stefank@xxxxxxxxxx>
> Signed-off-by: Stefan Kristiansson <stefank@xxxxxxxxxx>
> Signed-off-by: Peter De Schrijver <pdeschrijver@xxxxxxxxxx>
> ---
> .../firmware/nvidia,tegra186-bpmp.yaml | 37 +++++++++++++++++--
> 1 file changed, 34 insertions(+), 3 deletions(-)

We usually use a longer subject prefix, even though that makes the whole
subject usually become longer than the recommended 50 (or so)

Maybe you also want to add a verb to the subject to make it more
descriptive. As it is the subject doesn't indicate what's happening with
the memory-region property. It could equally well get removed.


Attachment: signature.asc
Description: PGP signature