Re: [PATCH] dmaengine: idxd: Fix passing freed memory in idxd_cdev_open()

From: Fenghua Yu
Date: Wed May 10 2023 - 18:08:03 EST

On 5/8/23 23:07, Harshit Mogalapalli wrote:
Smatch warns:
idxd_cdev_open() warn: 'sva' was already freed.

When idxd_wq_set_pasid() fails, the current code unbinds sva and then
goes to 'failed_set_pasid' where iommu_sva_unbind_device is called
again causing the above warning.
[ device_user_pasid_enabled(idxd) is still true when calling
failed_set_pasid ]

Fix this by removing additional unbind when idxd_wq_set_pasid() fails

Fixes: b022f59725f0 ("dmaengine: idxd: add idxd_copy_cr() to copy user completion record during page fault handling")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>

Acked-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>