Re: [PATCH v3 1/5] dt-bindings: power: Add JH7110 AON PMU support
From: Changhuang Liang
Date: Wed May 10 2023 - 22:06:34 EST
On 2023/5/11 3:51, Conor Dooley wrote:
> On Wed, May 10, 2023 at 03:20:14PM +0800, Changhuang Liang wrote:
>> On 2023/5/10 15:06, Conor Dooley wrote:
>>> On Tue, May 09, 2023 at 06:53:07PM -0700, Changhuang Liang wrote:
>>>> + - starfive,jh7110-pmu
>>>> + - items:
>>>> + - enum:
>>>> + - starfive,jh7110-aon-syscon
>>>> + - const: syscon
>>> Unfortunately, this is not what was wanted.
>>> This syscon, of which power domain control is just one of the things that
>>> it can do, should be documented in
>>> alongside it's brethern "starfive,jh7110-sys-syscon" &
>> That means that I don't need to modify this original yaml file?
> Does "this original" mean starfive,jh7100-pmu.yaml?
> If so then...
>> I just need to move current changes in this patch into
> It makes most sense for that binding, as it depends on the pll binding
> (because it has a ref: to it), to go through the clock tree in Xingyu's
> I'll apply the driver changes once the binding has been applied.
I think that I have to send v4 after Xingyu's series resend new version.
If drivers have no other comments. I will make the following changes:
patch 1/5: Only keep the content in starfive,jh7110-pmu.h, move other content into Xingyu's PLL series.
patch 5/5: Drop this patch, move the content into Xingyu's PLL series.
other patch: no change.