Re: [PATCH v2 2/5] ASoC: dt-bindings: Add tas2781 amplifier
From: Mark Brown
Date: Thu May 11 2023 - 01:49:29 EST
On Wed, May 10, 2023 at 09:04:26AM +0200, Krzysztof Kozlowski wrote:
> On 08/05/2023 07:45, Shenghao Ding wrote:
> > - Submit together with tas2781 codec driver code
> Fix your patchset threading. I don't think it's possible to apply your one.
While it would be nice if things were fixed (if git send-email is being
used then passing all the patches to one git send-email command should
do the trick) it's not an insurmountable obstacle.
> > + ti,audio-slots:
> > + description:
> > + Multiple tas2781s aggregate as one Audio Amp to support
> > + multiple audio slots
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + maxItems: 4
> You said you can have here two addresses. You don't allow it, test it.
> Missing minItems, but...
> > + items:
> > + minimum: 0x38
> > + maximum: 0x3f
> ... So these are fixed? No need to encode them in such case...
I'm not sure I understand your concern here, there's up to 4 possible
values from 0x38-0x3f which has more than 4 possible values.
Attachment:
signature.asc
Description: PGP signature