Re: [PATCH] procfs: Replace all non-returning strlcpy with strscpy
From: Kees Cook
Date: Thu May 11 2023 - 12:25:54 EST
On Wed, May 10, 2023 at 09:24:57PM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated .
> In an effort to remove strlcpy() completely , replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>  https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
>  https://github.com/KSPP/linux/issues/89
> Signed-off-by: Azeem Shaikh <azeemshaikh38@xxxxxxxxx>
Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>