Re: [PATCH 0/3] riscv: sbi: Switch to the sys-off handler API

From: Palmer Dabbelt
Date: Thu May 11 2023 - 16:53:29 EST

On Wed, 28 Dec 2022 08:19:12 PST (-0800), samuel@xxxxxxxxxxxx wrote:
I want to convert the axp20x PMIC poweroff handler to use the sys-off
API, so it can be used as a fallback for if the SBI poweroff handler
is unavailable. But the SBI poweroff handler still uses pm_power_off, so
done alone, this would cause the axp20x callback to be called first,
before the SBI poweroff handler has a chance to run.

In order to prevent this change in behavior, the SBI poweroff handler
needs to be converted to the sys-off API first, at a higher priority.

This series performs the conversion, after accounting for the fact that
the SBI poweroff handler is registered quite early during boot.

The first patch is a dependency for both this series and the PSCI
series[1], so I would like to get at least patch 1 merged soon.


Samuel Holland (3):
kernel/reboot: Use the static sys-off handler for any priority
riscv: sbi: Share the code for unsupported extension warnings
riscv: sbi: Switch to the sys-off handler API

arch/riscv/include/asm/sbi.h | 1 -
arch/riscv/kernel/sbi.c | 63 +++++++++++++++++++++---------------
kernel/reboot.c | 10 +++---
3 files changed, 41 insertions(+), 33 deletions(-)

Samuel: do you mind rebasing this and resending it with the reboot folks in the To list? That way we might be able to get an Ack on the generic bits.