Re: [PATCH v8 4/6] gpio: Add support for Intel LJCA USB GPIO driver

From: Linus Walleij
Date: Thu May 11 2023 - 17:07:59 EST

On Thu, May 11, 2023 at 8:01 PM Ye Xiang <> wrote:

> Implements the GPIO function of Intel USB-I2C/GPIO/SPI adapter
> device named "La Jolla Cove Adapter" (LJCA). It communicate with
> LJCA GPIO module with specific protocol through interfaces exported
> by LJCA USB driver.
> Signed-off-by: Ye Xiang <>

Overall this looks very nice.

> +static int gpio_config(struct ljca_gpio_dev *ljca_gpio, u8 gpio_id, u8 config)

All other functions are prefixed ljca_* except this one, so I think you
should do that on this one too.

With that fixes:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Linus Walleij