Re: [PATCH v2 00/18] Venus QoL / maintainability fixes
From: Bryan O'Donoghue
Date: Thu May 11 2023 - 23:01:35 EST
On 04/05/2023 09:00, Konrad Dybcio wrote:
Tested on 8250, but pretty please test it on your boards too!
What's the definition of test here ?
I ran this
ffplay -codec:video h264_v4l2m2m FantasticFour-ROTSS.mp4
ffplay -codec:video vp8_v4l2m2m /mnt/big-buck-bunny_trailer.webm
on db410c with no errors. Then again I applied and disapplied the 8x8
264 fix to that branch and saw no discernable difference so I'm not very
confident we have good coverage.
@Stan @Vikash could you give some suggested tests for coverage here ?
@Konrad - get a db410c !
My superficial first-pass on this series looks good but, before giving a
Tested-by here, I think we should define a set of coverage tests, run
them - the upper end on sm8250 and lower end msm8916 "makes sense to me"
20? different gstreamer tests at different formats and different sizes
on our selected platforms db410c, rb5, rb3 I have - also an 820 I
haven't booted and an enforce sdm660.
Which tests will we use to validate this series and subsequent series to
ensure we don't have more regressions ?