Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros
From: Jani Nikula
Date: Fri May 12 2023 - 07:45:43 EST
On Fri, 12 May 2023, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> On Fri, May 12, 2023 at 02:25:18PM +0300, Jani Nikula wrote:
>> On Fri, 12 May 2023, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>> > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote:
>> >> Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create
>> >> masks for fixed-width types and also the corresponding BIT_U32(),
>> >> BIT_U16() and BIT_U8().
>> > Why?
>> The main reason is that GENMASK() and BIT() size varies for 32/64 bit
> When needed GENMASK_ULL() can be used (with respective castings perhaps)
> and BIT_ULL(), no?
How does that help with making them the same 32-bit size on both 32 and
64 bit builds?
Jani Nikula, Intel Open Source Graphics Center