Re: [PATCH v2] dmaengine: pl330: rename _start to prevent build error

From: Vinod Koul
Date: Wed May 24 2023 - 01:47:22 EST


On 23-05-23, 21:53, Randy Dunlap wrote:
> "_start" is used in several arches and proably should be reserved
> for ARCH usage. Using it in a driver for a private symbol can cause
> a build error when it conflicts with ARCH usage of the same symbol.
>
> Therefore rename pl330's "_start" to "pl330_start_thread" so that there
> is no conflict and no build error.
>
> drivers/dma/pl330.c:1053:13: error: '_start' redeclared as different kind of symbol
> 1053 | static bool _start(struct pl330_thread *thrd)
> | ^~~~~~
> In file included from ../include/linux/interrupt.h:21,
> from ../drivers/dma/pl330.c:18:
> arch/riscv/include/asm/sections.h:11:13: note: previous declaration of '_start' with type 'char[]'
> 11 | extern char _start[];
> | ^~~~~~

Applied, thanks

--
~Vinod