Re: [RFC PATCH 2/4] remoteproc: Add TEE support

From: Christoph Hellwig
Date: Wed May 24 2023 - 02:52:05 EST


On Tue, May 23, 2023 at 11:13:48AM +0200, Arnaud Pouliquen wrote:
> + struct tee_param param[MAX_TEE_PARAM_ARRY_MEMB];
> + struct tee_shm *fw_shm;
> + int ret;
> +
> + fw_shm = tee_shm_register_kernel_buf(tee_rproc_ctx->tee_ctx, (void *)fw->data, fw->size);
> + if (IS_ERR(fw_shm)) {
> + /* Fallback: Try to allocate memory in OP-TEE space */
> + fw_shm = tee_shm_alloc_kernel_buf(tee_rproc_ctx->tee_ctx, fw->size);

> +EXPORT_SYMBOL(tee_rproc_load_fw);

Please stick to the EXPORT_SYMBOL_GPL of the underlying tee
infrastructure.