Re: [PATCH v10 03/11] stmpe-spi: Fix MODULE_DEVICE_TABLE entries
From: Luis Chamberlain
Date: Wed May 24 2023 - 02:54:11 EST
On Thu, Apr 06, 2023 at 02:00:22PM -0500, Allen Webb wrote:
> A one character difference in the name supplied to MODULE_DEVICE_TABLE
> breaks compilation for STMPE_SPI after built-in modules can generate
> match-id based module aliases. Since this wasn't being used before and
> builtin aliases aren't needed in this case, remove it.
>
> This was not caught earlier because STMPE_SPI can not be built as a
> module and MODULE_DEVICE_TABLE is a no-op for built-in modules.
>
> Fixes: e789995d5c61 ("mfd: Add support for STMPE SPI interface")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Link: https://lore.kernel.org/lkml/202212171140.NB93eVvI-lkp@xxxxxxxxx/
> Signed-off-by: Allen Webb <allenwebb@xxxxxxxxxx>
> ---
Oh feel free to add Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
on patches 1-3.
Luis