RE: [PATCH 1/1] cdx: Rename MCDI_LOGGING to CDX_MCDI_LOGGING

[Gangurde, Abhijit]

Hi Greg,

<snip>
> >
> > -#ifdef CONFIG_MCDI_LOGGING
> > +#ifdef CONFIG_CDX_MCDI_LOGGING
> >       mcdi->logging_buffer = kmalloc(LOG_LINE_MAX, GFP_KERNEL);
> >       if (!mcdi->logging_buffer)
> >               goto fail2;
> 
> This mess of #ifdef in the .c files is not ok.
> 
> Please move all of this "logging" stuff out into proper .h definitions
> so that it's not in the .c code at all.
> 

Sure, will cleanup the #ifdefs in c file.
Will also update logging to be controlled by sysfs in next spin.

> thanks,
> 
> greg k-h