Re: [PATCH 0/3] tools/nolibc: stack protector compatibility fixes

From: Willy Tarreau
Date: Wed May 24 2023 - 03:36:13 EST


Hi Thomas,

On Wed, May 24, 2023 at 08:44:41AM +0200, Thomas Weißschuh wrote:
> Two fixes for nolibc to
> * allow users to explicitly disable (or theoretically enable) when
> building the tests
> * fix stackprotectors on GCC < 10.

Nice, thank you. Just tested with gcc 9.5, works both with and without
stkp. Now pushed to branch 20230524-nolibc-rv32+stkp4. I've dropped my
exp patch and the associated revert. I think your two patches that clean
up the makefile options and the new one here that restores the cflags
should be squashed since the latter just partially reverts the former,
and that way the series remains bisectable. Just let me know if you're
OK, I can just to that and re-push.

Have a nice day!
Willy