Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs

From: Christian Brauner
Date: Wed May 24 2023 - 05:12:13 EST


On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote:
> An output message:
>
> > # # waitpid WEXITSTATUS=0
>
> will be printed for 30,000+ times in the `pidfd_test` selftest, which
> does not seem ideal. This patch removes the print logic in the
> `wait_for_pid` function, so each call to this function does not output
> a line by default. Any existing call sites where the extra line might
> be beneficial have been modified to include extra print statements
> outside of the function calls.
>
> Signed-off-by: Ziqi Zhao <astrajoan@xxxxxxxxx>
> ---

Fine by me,
Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>