Re: [PATCH v5 13/15] crypto: iaa - Add support for default IAA 'canned' compression mode

From: Herbert Xu
Date: Wed May 24 2023 - 05:50:47 EST


On Tue, May 16, 2023 at 04:50:07PM -0500, Tom Zanussi wrote:
.
> To choose 'fixed' mode:
>
> echo "fixed" > /sys/bus/dsa/drivers/crypto/compression_mode
>
> To choose 'canned' mode:
>
> echo "canned" > /sys/bus/dsa/drivers/crypto/compression_mode

This seems to be a strange way to switch modes. How about just
registering both algorithms and then let the user decide which
one to use throught the algorithm name?

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt