Re: [PATCH] crypto: aegis: add header for internal prototypes

[Herbert Xu]

On Tue, May 16, 2023 at 10:28:48PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> gcc warns if prototypes are only visible to the caller but
> not the callee:
> 
> crypto/aegis128-neon-inner.c:134:6: warning: no previous prototype for 'crypto_aegis128_init_neon' [-Wmissing-prototypes]
> crypto/aegis128-neon-inner.c:164:6: warning: no previous prototype for 'crypto_aegis128_update_neon' [-Wmissing-prototypes]
> crypto/aegis128-neon-inner.c:221:6: warning: no previous prototype for 'crypto_aegis128_encrypt_chunk_neon' [-Wmissing-prototypes]
> crypto/aegis128-neon-inner.c:270:6: warning: no previous prototype for 'crypto_aegis128_decrypt_chunk_neon' [-Wmissing-prototypes]
> crypto/aegis128-neon-inner.c:316:5: warning: no previous prototype for 'crypto_aegis128_final_neon' [-Wmissing-prototypes]
> 
> The prototypes cannot be in the regular aegis.h, as the inner neon code
> cannot include normal kernel headers. Instead add a new header just for
> the functions provided by this file.
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  crypto/aegis-neon.h          | 17 +++++++++++++++++
>  crypto/aegis128-neon-inner.c |  1 +
>  crypto/aegis128-neon.c       | 12 +-----------
>  3 files changed, 19 insertions(+), 11 deletions(-)
>  create mode 100644 crypto/aegis-neon.h

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt