Re: [PATCH 1/4] clk: qcom: clk-alpha-pll: Add support for lucid ole pll ops

From: Jagadeesh Kona
Date: Wed May 24 2023 - 10:27:52 EST

Hi Konrad,

Thanks for your review!

On 5/19/2023 6:39 PM, Konrad Dybcio wrote:

On 19.05.2023 14:49, Jagadeesh Kona wrote:

Thanks Konrad for your review!

On 5/10/2023 1:36 AM, Konrad Dybcio wrote:

On 9.05.2023 18:12, Jagadeesh Kona wrote:
From: Taniya Das <quic_tdas@xxxxxxxxxxx>

Add support for lucid ole pll ops to configure and control the
lucid ole pll. The lucid ole pll has an additional test control
register which is required to be programmed, add support to
program the same.

Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
Signed-off-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx>
Isn't this commit "write to PLL_TEST_CTL_U2 on LUCID_EVO" instead?

Meaninglessly duplicating ops does not seem useful.


Though we are reusing same ops for EVO and OLE, PLL_TEST_CTL_U2 register programming is applicable only to OLE PLL type.
Well, your patch makes it unconditional (modulo programmer error) so
I think that makes little sense.. A comment would be enough, imo.

Yes, will remove the duplicate definitions and will reuse the existing ops.

And PLL type is useful to properly refer respective hardware datasheets. Hence added separate ops for OLE PLL type.

Thanks & Regards,