Re: [PATCH] x86/pci/xen: populate MSI sysfs entries

[Juergen Gross]

On 24.05.23 17:43, Maximilian Heyne wrote:
> On Wed, May 03, 2023 at 01:16:53PM +0000, Maximilian Heyne wrote:
> > Commit bf5e758f02fc ("genirq/msi: Simplify sysfs handling") reworked the
> > creation of sysfs entries for MSI IRQs. The creation used to be in
> > msi_domain_alloc_irqs_descs_locked after calling ops->domain_alloc_irqs.
> > Then it moved into __msi_domain_alloc_irqs which is an implementation of
> > domain_alloc_irqs. However, Xen comes with the only other implementation
> > of domain_alloc_irqs and hence doesn't run the sysfs population code
> > anymore.
> >
> > Commit 6c796996ee70 ("x86/pci/xen: Fixup fallout from the PCI/MSI
> > overhaul") set the flag MSI_FLAG_DEV_SYSFS for the xen msi_domain_info
> > but that doesn't actually have an effect because Xen uses it's own
> > domain_alloc_irqs implementation.
> >
> > Fix this by making use of the fallback functions for sysfs population.
> >
> > Fixes: bf5e758f02fc ("genirq/msi: Simplify sysfs handling")
> > Signed-off-by: Maximilian Heyne <mheyne@xxxxxxxxx>
>
>
> Any other feedback on this one? This is definitely a bug but I understand that
> there might be different ways to fix it.

I'd be happy to take the patch via the Xen tree, but I think x86 maintainers
should at least ack that.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature