Re: [PATCH v3] PCI: Don't assume root ports from > 2015 are power manageable

From: Lukas Wunner
Date: Wed May 24 2023 - 11:55:34 EST


On Wed, May 24, 2023 at 10:21:36AM -0500, Mario Limonciello wrote:
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -2976,6 +2976,9 @@ bool pci_bridge_d3_possible(struct pci_dev *bridge)
>
> switch (pci_pcie_type(bridge)) {
> case PCI_EXP_TYPE_ROOT_PORT:
> + if (!platform_pci_power_manageable(bridge))
> + return false;
> + fallthrough;
> case PCI_EXP_TYPE_UPSTREAM:
> case PCI_EXP_TYPE_DOWNSTREAM:
> if (pci_bridge_d3_disable)

This will exempt the Root Ports from pcie_port_pm=force.
Not sure if that's desirable.

Thanks,

Lukas