Re: [PATCH 2/3] clk: qcom: gpucc-sm8550: Add support for graphics clock controller

[Jagadeesh Kona]

Hi Dmitry,

Thanks for your review!

On 5/20/2023 4:35 AM, Dmitry Baryshkov wrote:
> On 20/05/2023 00:36, Jagadeesh Kona wrote:
> > Add support for gpucc driver on SM8550, which provides clocks for the
> > graphics subsystem.
> >
> > Signed-off-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx>
> > Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
>
> Jagadeesh, if you are submitting a patch, your sign-off should be the 
> last one. If Taniya participated in development of the driver, you might 
> want to add the "Co-Developed-by" tag in addition to existing ones.
Yes, will take care of this in next series.

> > ---
> >   drivers/clk/qcom/Kconfig        |   8 +
> >   drivers/clk/qcom/Makefile       |   1 +
> >   drivers/clk/qcom/gpucc-sm8550.c | 609 ++++++++++++++++++++++++++++++++
> >   3 files changed, 618 insertions(+)
> >   create mode 100644 drivers/clk/qcom/gpucc-sm8550.c
>
> [skipped]
>
> > +static int __init gpu_cc_sm8550_init(void)
> > +{
> > +    return platform_driver_register(&gpu_cc_sm8550_driver);
> > +}
> > +subsys_initcall(gpu_cc_sm8550_init);
>
> module_device_driver
We need to evaluate if module_init_call works for all our usecases,
we will revisit and post a cleanup patch once we conclude module_init is 
sufficient for all our usecases.

> > +
> > +static void __exit gpu_cc_sm8550_exit(void)
> > +{
> > +    platform_driver_unregister(&gpu_cc_sm8550_driver);
> > +}
> > +module_exit(gpu_cc_sm8550_exit);
> > +
> > +MODULE_DESCRIPTION("QTI GPU_CC SM8550 Driver");
> > +MODULE_LICENSE("GPL");

Thanks & Regards,
Jagadeesh