Re: [PATCH v4 09/36] arm64: Implement the new page table range API
From: Anshuman Khandual
Date: Thu May 25 2023 - 00:43:35 EST
On 5/25/23 09:35, Matthew Wilcox wrote:
> On Thu, May 25, 2023 at 09:05:35AM +0530, Anshuman Khandual wrote:
>>> @@ -127,6 +127,8 @@ extern void copy_to_user_page(struct vm_area_struct *, struct page *,
>>> */
>>> #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1
>>> extern void flush_dcache_page(struct page *);
>>> +void flush_dcache_folio(struct folio *);
>>
>> This is giving a checkpatch.pl warning
>>
>> WARNING: function definition argument 'struct folio *' should also have an identifier name
>> #36: FILE: arch/arm64/include/asm/cacheflush.h:130:
>> +void flush_dcache_folio(struct folio *);
>
> Yes, but checkpatch is *stupid*. Don't just follow tools blindly.
> How is naming the parameter here helping anyone?
Agreed, it seemed bit weird. Never mind.