Re: [PATCH v6 RESEND 0/4] Add Acer Aspire 1
From: Bjorn Andersson
Date: Thu May 25 2023 - 00:57:00 EST
On Mon, 15 May 2023 14:37:40 +0500, Nikita Travkin wrote:
> This series introduces Acer Aspire 1 - A WoA laptop with sc7180.
>
> The dts adds mostly complite support for the hardware and the device,
> with minor patches on top, can be used as a normal laptop daily.
>
> Notable features absent from this patch:
> - Sound
> While the dedicated sound components are defined, since the
> ADSP must be used, sound requires additions of that remoteproc
> as well some extra "glue" to connect the i2s outputs to it.
> I was able to hack together some sound based on sm8250 stuff
> but it needs more work.
> - Embedded Controller
> The laptop has a dedicated EC that controls, notably,
> battery/charger and notifies the device about the USB-C DisplayPort
> HPD events. As per this patch, there is no battery status
> indication and external display support. Also, due to the EC
> defaults, the fn key is disabled. I have an experimental driver that
> implements all of that, which needs more work and will be submitted
> at a later date.
> - PSCI OSI Mode
> Firmware on this laptop does not support the PC mode, as is usual
> for Qualcomm. This change would require adding OSI related
> power-domains to the SoC dtsi and is omitted in expectation that
> this can be handled when (if?) CrOS team handles their tf-a, like
> they did with sc7280.
>
> [...]
Applied, thanks!
[1/4] arm64: dts: qcom: sc7180: Don't enable lpass clocks by default
commit: 43926a3cb19180b4fc6cd0d72bbefc7e93592f91
[2/4] arm64: dts: qcom: sc7180: Drop redundant disable in mdp
commit: 39238382c4991d7d9442de4aa6636b19355be1e9
[3/4] dt-bindings: arm: qcom: Add Acer Aspire 1
commit: aaffd364118bbc5b20c0a92f82780ea22e1c3f07
[4/4] arm64: dts: qcom: Add Acer Aspire 1
commit: 4a9f8f8f2adaa05abfdec7c588c8dab3281048f0
Best regards,
--
Bjorn Andersson <andersson@xxxxxxxxxx>