Re: [PATCH v2] usb: common: usb-conn-gpio: Set last role to unknown before initial detection

From: Prashanth K
Date: Thu May 25 2023 - 04:28:14 EST

On 25-05-23 01:37 pm, AngeloGioacchino Del Regno wrote:
Il 24/05/23 15:50, Prashanth K ha scritto:
Currently if we bootup a device without cable connected, then
usb-conn-gpio won't call set_role() since last_role is same as
current role. This happens because during probe last_role gets
initialized to zero.

To avoid this, added a new constant in enum usb_role, last_role
is set to USB_ROLE_UNKNOWN before performing initial detection.

Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection detection driver")
Signed-off-by: Prashanth K <quic_prashk@xxxxxxxxxxx>

There's an issue with drivers/usb/cdns3/core.c as pointed out by the
test robot; the solution is to handle `default` in the switch, I'd say
that it would be safe to handle it as


after solving that:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Yea sure, thanks for the suggestion Agnelo

Prashanth K