RE: [PATCH net-next] net: fec: remove last_bdp from fec_enet_txq_xmit_frame()

[Wei Fang]

> -----Original Message-----
> From: Simon Horman <simon.horman@xxxxxxxxxxxx>
> Sent: 2023年5月25日 17:09
> To: Wei Fang <wei.fang@xxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; Shenwei Wang <shenwei.wang@xxxxxxx>; Clark Wang
> <xiaoning.wang@xxxxxxx>; netdev@xxxxxxxxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next] net: fec: remove last_bdp from
> fec_enet_txq_xmit_frame()
> 
> On Thu, May 25, 2023 at 04:38:24PM +0800, wei.fang@xxxxxxx wrote:
> > From: Wei Fang <wei.fang@xxxxxxx>
> >
> > Actually, the last_bdp is useless in fec_enet_txq_xmit_frame(), so
> > remove it.
> 
> I think it would be useful to describe why it is useless.
> 
> F.e. because it is set to bdp, which doesn't change, so bdp can be used directly
> instead.
> 
Sorry, I'll refine the commit message in the next version. Thank you!