Re: [PATCH 3/4] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550

From: Jagadeesh Kona
Date: Thu May 25 2023 - 12:50:15 EST

Hi Bryan,

Thanks for your review!

On 5/20/2023 1:56 AM, Bryan O'Donoghue wrote:
On 19/05/2023 16:56, Jagadeesh Kona wrote:

This pattern looks odd and inconsistent in our clock drivers. We mostly have CAMCC or VIDEOCC but occasionally have CAM_CC and VIDEO_CC.

I'd drop that underscore to, in addition to Konrad's comment on Ucase hex.

Other than that, LGTM.

Will take care of this in next series.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

Thanks & Regards,