Re: [PATCH 2/4] dt-bindings: clock: qcom: Add SM8550 camera clock controller

From: Jagadeesh Kona
Date: Thu May 25 2023 - 12:58:58 EST

Hi Conor,

Thanks for your review!

On 5/19/2023 10:18 PM, Conor Dooley wrote:
On Fri, May 19, 2023 at 09:26:00PM +0530, Jagadeesh Kona wrote:
Add device tree bindings for the camera clock controller on
Qualcomm SM8550 platform.

Signed-off-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx>
Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>

Should this SoB go with a Co-developed-by?
I'll leave it up to Krzysztof or someone else familiar with qcom
products as to whether there's an existing binding that this should be
added to, but qcom,videocc.yaml seems "suspect" to an outsider.

Otherwise, what you have here looks fine to me.

Will reuse SM8450 CAMCC YAML file for SM8550

Thanks & Regards,