Re: [PATCH v6 04/10 RESEND] mfd: rt5033: Apply preparatory changes before adding rt5033-charger driver

[Jakob Hauser]

Hi Lee,

On 25.05.23 12:44, Lee Jones wrote:
> On Mon, 15 May 2023, Jakob Hauser wrote:

...

> > diff --git a/include/linux/mfd/rt5033.h b/include/linux/mfd/rt5033.h
> > index 8f306ac15a27..e99e2ab0c1c1 100644
> > --- a/include/linux/mfd/rt5033.h
> > +++ b/include/linux/mfd/rt5033.h
> > @@ -51,7 +51,7 @@ struct rt5033_charger_data {
> >   struct rt5033_charger {
> >   	struct device			*dev;
> >   	struct rt5033_dev		*rt5033;
> > -	struct power_supply		psy;
> > +	struct power_supply		*psy;
>
> Is this current unused?

Currently this is not in use. The rt5033 charger driver gets introduced 
by this pachset.

The struct rt5033_charger was added in Dec 2014 with the mfd driver [1] 
but the charger driver didn't make it [2] and further effort to 
implement it phased out [3].

[1] https://lore.kernel.org/lkml/20141209140102.GZ3951@x1
[2] https://lore.kernel.org/lkml/20150122183037.GA24898@earth.universe
[3] 
https://lore.kernel.org/lkml/1425864191-4121-1-git-send-email-beomho.seo@xxxxxxxxxxx/T/#t

> >   	struct rt5033_charger_data	*chg;
> >   };
> >   

Kind regards,
Jakob