Re: [PATCH v3 3/3] PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
From: Dan Carpenter
Date: Fri May 26 2023 - 01:37:14 EST
Hi Thippeswamy,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Thippeswamy-Havalige/Move-and-rename-error-interrupt-bits-to-a-common-header/20230519-190203
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20230519105901.2399452-4-thippeswamy.havalige%40amd.com
patch subject: [PATCH v3 3/3] PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
config: loongarch-randconfig-m041-20230521
compiler: loongarch64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <error27@xxxxxxxxx>
| Closes: https://lore.kernel.org/r/202305261250.2cs1phTS-lkp@xxxxxxxxx/
New smatch warnings:
drivers/pci/controller/pcie-xilinx-dma-pl.c:562 xilinx_pl_dma_pcie_init_irq_domain() warn: passing zero to 'PTR_ERR'
drivers/pci/controller/pcie-xilinx-dma-pl.c:600 xilinx_pl_dma_pcie_setup_irq() warn: unsigned 'port->irq' is never less than zero.
Old smatch warnings:
drivers/pci/controller/pcie-xilinx-dma-pl.c:576 xilinx_pl_dma_pcie_init_irq_domain() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +562 drivers/pci/controller/pcie-xilinx-dma-pl.c
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 551 static int xilinx_pl_dma_pcie_init_irq_domain(struct pl_dma_pcie *port)
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 552 {
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 553 struct device *dev = port->dev;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 554 struct device_node *node = dev->of_node;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 555 struct device_node *pcie_intc_node;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 556 int ret;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 557
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 558 /* Setup INTx */
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 559 pcie_intc_node = of_get_child_by_name(node, "interrupt-controller");
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 560 if (!pcie_intc_node) {
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 561 dev_err(dev, "No PCIe Intc node found\n");
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 @562 return PTR_ERR(pcie_intc_node);
PTR_ERR(NULL) is success.
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 563 }
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 564
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 565 port->pldma_domain = irq_domain_add_linear(pcie_intc_node, 32,
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 566 &event_domain_ops, port);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 567 if (!port->pldma_domain)
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 568 return -ENOMEM;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 569
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 570 irq_domain_update_bus_token(port->pldma_domain, DOMAIN_BUS_NEXUS);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 571
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 572 port->intx_domain = irq_domain_add_linear(pcie_intc_node, PCI_NUM_INTX,
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 573 &intx_domain_ops, port);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 574 if (!port->intx_domain) {
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 575 dev_err(dev, "Failed to get a legacy IRQ domain\n");
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 576 return PTR_ERR(port->intx_domain);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 577 }
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 578
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 579 irq_domain_update_bus_token(port->intx_domain, DOMAIN_BUS_WIRED);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 580
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 581 ret = xilinx_pl_dma_pcie_init_msi_irq_domain(port);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 582 if (ret != 0) {
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 583 irq_domain_remove(port->intx_domain);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 584 return -ENOMEM;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 585 }
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 586
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 587 of_node_put(pcie_intc_node);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 588 raw_spin_lock_init(&port->lock);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 589
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 590 return 0;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 591 }
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 592
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 593 static int xilinx_pl_dma_pcie_setup_irq(struct pl_dma_pcie *port)
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 594 {
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 595 struct device *dev = port->dev;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 596 struct platform_device *pdev = to_platform_device(dev);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 597 int i, irq;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 598
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 599 port->irq = platform_get_irq(pdev, 0);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 @600 if (port->irq < 0)
^^^^^^^^^^^^^
unsigned isn't less than zero. Presumably other checkers have already
complained about this...
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 601 return port->irq;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 602
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 603 for (i = 0; i < ARRAY_SIZE(intr_cause); i++) {
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 604 int err;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 605
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 606 if (!intr_cause[i].str)
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 607 continue;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 608
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 609 irq = irq_create_mapping(port->pldma_domain, i);
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 610 if (!irq) {
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 611 dev_err(dev, "Failed to map interrupt\n");
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 612 return -ENXIO;
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 613 }
3edd32a3a46e2d Thippeswamy Havalige 2023-05-19 614
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki