Re: [PATCH v2 1/5] block: annotate bdev_disk_changed() deprecation with a symbol namespace

From: Christoph Hellwig
Date: Fri May 26 2023 - 04:13:31 EST

On Fri, May 26, 2023 at 12:33:32AM -0700, Luis Chamberlain wrote:
> This ensures no other users pop up by mistake easily and provides
> us a with an easy vehicle to do the same with other routines should
> we need it later.

I don't see how this is related to the rest of the seris. I also don't
think it's a good idea. The APIs isn't deprecated per se. It just
should not be called by drivers. The right thing would be an interface

EXPORT_SYMBOL_GPL_FOR(bdev_disk_changed, loop.ko, CONFIG_BLK_DEV_LOOP);
EXPORT_SYMBOL_GPL_FOR(bdev_disk_changed, dasd_mod.ko, CONFIG_DASD);

with the modulo code enforcing that no one but the module this is
explicitly exorted for can use the symbol.