Re: [PATCH] auxdisplay: Switch i2c drivers back to use .probe()

From: Uwe Kleine-König
Date: Fri May 26 2023 - 09:00:12 EST


hello Miguel,

On Fri, May 26, 2023 at 12:39:55PM +0200, Miguel Ojeda wrote:
> On Thu, May 25, 2023 at 10:58 PM Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> >
> > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> > call-back type"), all drivers being converted to .probe_new() and then
> > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> > convert back to (the new) .probe() to be able to eventually drop
> > .probe_new() from struct i2c_driver.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> Thanks for this! The conversion has taken a while given the date of
> the first commit :)
>
> The wording of the message was a bit confusing, perhaps a ";
> finally/now" before "convert" would have helped, but no big deal.
>
> If somebody is taking all the patches treewide, then:
>
> Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
>
> Otherwise, I will queue it.

The overall idea was to make the changes in a way to require no
coordination between maintainers. So adding this change to your tree
would be great.

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature