Re: [PATCH net-next v3 2/6] net: phy: microchip_t1s: replace read-modify-write code with phy_modify_mmd

From: Parthiban.Veerasooran
Date: Fri May 26 2023 - 10:15:11 EST

Hi Ramon,

On 26/05/23 7:32 pm, Ramón Nordin Rodriguez wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>> /* Reference to AN1699
>>>> *
>>>> * AN1699 says Read, Modify, Write, but the Write is not required if
>>>> the register already has the required value. So it is safe to use
>>>> phy_modify_mmd here.
>>>> */
>>>> So in future, if someone wants to know about this configuration they can
>>>> simply refer the AN1699.
>>>> What do you think?
>>> I'm not sure about the link, resources have a tendency to move.
>> Yes, I agree with you but somehow there is no way for giving the
>> reference to this document. May be we will keep this link for the
>> reference, later if someone is not able to access the link then they can
>> request Microchip to get the document.
>> What do you think about this proposal? If you agree then I will proceed
>> for preparing the next version with your comments.
> Thumbs up from me

Best Regards,
Parthiban V
> R
>>> Otherwise LGTM
>>>> Best Regards,
>>>> Parthiban V