Re: [PATCH 5/7] drm/apu: allow platform driver to implement their own mmap function

[Alexandre Bailon]

On 5/17/23 21:45, Krzysztof Kozlowski wrote:
> On 17/05/2023 16:52, Alexandre Bailon wrote:
> > From: Julien Stephan <jstephan@xxxxxxxxxxxx>
> >
> > By default we will call drm_gem_mmap() unless the apu driver has
> > declared it's own mmap handler.
> >
> > Signed-off-by: Julien Stephan <jstephan@xxxxxxxxxxxx>
> > Reviewed-by: Julien Stephan <jstephan@xxxxxxxxxxxx>
>
> One does not have to review own code. We all assume that we send good
> code which we do not have to review by ourselves (by the author). We
> also assume we make mistakes, which we cannot find, thus other person's
> review is important.
I am sorry, I am the one who made the misstake.
I squashed this patch with another one I made, lost my signedof and left 
the reviewed by which indeed doesn't make any sense.

Best Regards,
Alexandre
> Adding own review tag suggests you added them mechanically, so I doubt
> that they really happened.
>
> Anyway, your SoB is missing.
>
> Best regards,
> Krzysztof