Re: [PATCH v2] ASoC: SOF: imx: Add OF machine descriptors for i.MX platforms

From: Mark Brown
Date: Fri May 26 2023 - 11:32:35 EST


On Thu, May 25, 2023 at 09:35:40PM +0300, Daniel Baluta wrote:
> On Thu, May 25, 2023 at 8:07 PM Mark Brown <broonie@xxxxxxxxxx> wrote:

> > > + {
> > > + .compatible = "fsl,imx8qm",
> > > + .drv_name = "asoc-simple-card",
> > > + .sof_tplg_filename = "sof-imx8.tplg",
> > > + },

> > It seems a bit sad to be adding simple-card rather than audio-graph-card
> > at this point - is there some great reason for this?

> This is what we used so far and it works pretty well for us.

> Is there a plan to deprecate simple-card? And switch to audio-graph-card?

> We could have a look at this if this is the correct direction.

It's already deprecated, and audio-graph-card (really you want to use
the audio-graph-card2 binding) is much more featureful so will cover
more machines. If you're doing something new then it's best to use
audio-graph-card for future proofing, simple-card is a bit too simple
and inflexible.

Attachment: signature.asc
Description: PGP signature