Re: [PATCH] smb: delete an unnecessary statement

[Mukesh Ojha]

On 5/26/2023 5:31 PM, Dan Carpenter wrote:
> We don't need to set the list iterators to NULL before a
> list_for_each_entry() loop because they are assigned inside the
> macro.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>


Reviewed-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>

-Mukesh

> ---
>   fs/smb/client/smb2ops.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
> index 5065398665f1..6e3be58cfe49 100644
> --- a/fs/smb/client/smb2ops.c
> +++ b/fs/smb/client/smb2ops.c
> @@ -618,7 +618,6 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf,
>   		 * Add a new one instead
>   		 */
>   		spin_lock(&ses->iface_lock);
> -		iface = niface = NULL;
>   		list_for_each_entry_safe(iface, niface, &ses->iface_list,
>   					 iface_head) {
>   			ret = iface_cmp(iface, &tmp_iface);