Re: [PATCH v5 net 6/6] net/sched: qdisc_destroy() old ingress and clsact Qdiscs before grafting

From: Jamal Hadi Salim
Date: Fri May 26 2023 - 15:47:50 EST


On Fri, May 26, 2023 at 8:20 AM Jamal Hadi Salim <jhs@xxxxxxxxxxxx> wrote:
>
> On Wed, May 24, 2023 at 11:39 AM Pedro Tammela <pctammela@xxxxxxxxxxxx> wrote:
> >
> > On 23/05/2023 22:20, Peilin Ye wrote:
> > > From: Peilin Ye <peilin.ye@xxxxxxxxxxxxx>

> Acked-by: Jamal Hadi Salim <jhs@xxxxxxxxxxxx>

I apologize i am going to take this back, lets please hold the series for now.

In pursuit for the effect on events, Pedro and I spent a few _hours_
chasing this - and regardless of the events, there are still
challenges with the concurrency issue. The current reproducer
unfortunately cant cause damage after patch 2, so really patch 6 was
not being tested. We hacked the repro to hit codepath patch 6 fixes.
We are not sure what the root cause is - but it certainly due to the
series. Peilin, Pedro will post the new repro.

cheers,
jamal