Re: [PATCH 4/4] arm64: dts: qcom: sm8550-qrd: enable PMIC Volume and Power buttons

From: Konrad Dybcio
Date: Fri May 26 2023 - 15:53:15 EST




On 25.05.2023 17:47, Neil Armstrong wrote:
> The Volume Down & Power buttons are controlled by the PMIC via
> the PON hardware, and the Volume Up is connected to a PMIC gpio.
>
> Enable the necessary hardware and setup the GPIO state for the
> Volume Up gpio key.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 36 +++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> index b08a8201ad23..c354dcc12621 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> @@ -28,6 +28,22 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&volume_up_n>;
property-n
property-names

> +
> + key-volume-up {
> + label = "Volume Up";
> + linux,code = <KEY_VOLUMEUP>;
> + gpios = <&pm8550_gpios 6 GPIO_ACTIVE_LOW>;
> + debounce-interval = <15>;
> + linux,can-disable;
> + wakeup-source;
> + };
> + };
> +
> pmic-glink {
> compatible = "qcom,sm8550-pmic-glink", "qcom,pmic-glink";
> #address-cells = <1>;
> @@ -426,6 +442,16 @@ &pcie0_phy {
> status = "okay";
> };
>
> +&pon_pwrkey {
> + status = "okay";
> +};
> +
> +&pon_resin {
Not alphabetically ordered

Konrad
> + linux,code = <KEY_VOLUMEDOWN>;
> +
> + status = "okay";
> +};
> +
> &pm8550_flash {
> status = "okay";
>
> @@ -450,6 +476,16 @@ led-1 {
> };
> };
>
> +&pm8550_gpios {
> + volume_up_n: volume-up-n-state {
> + pins = "gpio6";
> + function = "normal";
> + power-source = <1>;
> + bias-pull-up;
> + input-enable;
> + };
> +};
> +
> &pm8550_pwm {
> status = "okay";
>
>