Re: x86 copy performance regression

From: Linus Torvalds
Date: Fri May 26 2023 - 16:37:39 EST


On Fri, May 26, 2023 at 11:33 AM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Anyway, I guess *this* avoids all issues. It creates an extra jump to
> a jump for the case where the CPU doesn't have ERMS, but I guess we
> don't really care about those CPUs anyway.

Well, I'm obviously wrong, because my very own CPU (AMD Zen 2) doesn't do ERMS.

But the extra 'jmp' doesn't seem to appreciably matter, so I guess I
don't care. It does show up in profiles, but only barely.

I've committed and pushed out the fix.

Linus