Re: [PATCH v2 1/3] dt-bindings: media: camss: qcom,msm8996-camss: Add CAMSS power domain

From: Yassine Oudjana
Date: Sat May 27 2023 - 02:05:35 EST



On Fri, May 26 2023 at 10:36:32 PM +02:00:00, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:


On 26.05.2023 22:21, Bryan O'Donoghue wrote:
On 26/05/2023 21:19, Conor Dooley wrote:
On Fri, May 26, 2023 at 09:05:47PM +0100, Bryan O'Donoghue wrote:
On 26/05/2023 20:46, Conor Dooley wrote:
+ - power-domain-names
Why is this now required?

Thanks,
Conor.


Its an accurate description of the power/clock tree to have the top power
domain be switched on prior to the clocks that depend on it.

But what does that have to do with the *names* now being required?

oh the names

no toss that
this should be

if:properties:compatible:blahblahmsm8996:then:required:power-domain-names

The only compatible in this binding is qcom,msm8996-camss, so what would this achieve?


Konrad


I think Yassine, you could probably include the majority of your
cover-letter text in this commit to explain this change a bit better.

I think it would be good to have that regardless.

Cheers,
Conor.

bod
^^^ I've been trying not to think about rugby since the weekend :(

Pockets O'Gara should have his paddy papers rescinded