Re: [PATCH v3 1/2] axis-fifo: use devm_kasprintf() for allocating formatted strings

From: Prathu Baronia
Date: Sat May 27 2023 - 04:53:29 EST

On Sat, May 27, 2023 at 08:35:57AM +0100, Greg KH wrote:
> Maybe error-prone, but all is fine with the original code, right?
Yes, all is fine with the original code. Replaced it only because it was error-prone.

> When you have "also" in a changelog commit, that usually means this
> needs to be split out into a separate patch. And that's the case here,
> make the first patch of the series fix the problem. Then do your
> cleanups on later patches.
Point taken, will split it in v4.

> > Fixes: d2d7aa53891e ("staging: axis-fifo: convert to use miscdevice")
> changing to a different string function does not fix anything.
Right, this should only be part of the smatch warning fixing commit.

> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> It did not report that you need to replace a string function, right?
> See, things got messy when you mixed in changes into one. Please break
> these up.
Understood, will do.